LCFS - Implement Email Notification Triggers in Backend for Subscribed Users #1226 #1402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backend Test Results493 tests ±0 491 ✅ ±0 1m 52s ⏱️ +4s For more details on these failures, see this check. Results for commit c77f4c6. ± Comparison against base commit 3c014c2. ♻️ This comment has been updated with latest results. |
prv-proton
requested review from
hamed-valiollahi and
kevin-hashimoto
and removed request for
hamed-valiollahi
AlexZorkin
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
is there a better place to keep this in the backend? Or is it used in enough places to justify having it in base?
There was a problem hiding this comment.
Thanks Alex for the review. Since this schema will be used across various services, it causes greenlet spawn error if placed inside the notifications schema, hence it's being placed inside the base.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1226